fix: remove session storage from TypeScript agent config#1306
Merged
Conversation
TypeScript agents do not support session storage, so hide the option from the TUI advanced settings and reject the CLI flag with a clear error message during validation.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1306-tarball/aws-agentcore-0.14.0.tgz |
Contributor
Coverage Report
|
agentcore-cli-automation
suggested changes
May 19, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Nice, focused fix. Two things worth addressing before merge — one is a real gap in the validation, the other is a missing test for the new branch.
github-actions
Bot
removed
the
agentcore-harness-reviewing
… test Addresses review feedback: - Move the TypeScript rejection to the top of validateAddAgentOptions so it runs before any protocol-specific early returns (MCP, import, etc.) - Add unit test asserting BYO+TypeScript+sessionStorageMountPath is rejected
aidandaly24
approved these changes
May 19, 2026
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--session-storage-mount-pathwith a clear error for TypeScript agents in non-interactive modeTest plan
agentcore add agent --language TypeScript --session-storage-mount-path /mnt/datareturns an error